melch/Marlin
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3184 from thinkyhead/fix_command_injection

Browse Source 
Patch drain_queued_commands_P
This commit is contained in:
Scott Lahteine 2016-03-19 20:12:16 -07:00
commit da94bcfebb
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Marlin/Marlin_main.cpp
View File

@ -491,23 +491,20 @@ extern "C" {
*/ */
static bool drain_queued_commands_P() { static bool drain_queued_commands_P() {
if (queued_commands_P != NULL) { if (queued_commands_P != NULL) {
// Get the next gcode to run
size_t i = 0; size_t i = 0;
char c; char c, cmd[30];
while ((c = queued_commands_P[i++]) && c != '\n') { }; strncpy_P(cmd, queued_commands_P, sizeof(cmd) - 1);
if (i > 1) { cmd[sizeof(cmd) - 1] = '\0';
char cmd[i]; while ((c = cmd[i]) && c != '\n') i++; // find the end of this gcode command
strncpy_P(cmd, queued_commands_P, i - 1); cmd[i] = '\0';
cmd[i - 1] = '\0'; if (enqueue_and_echo_command(cmd)) { // success?
if (enqueue_and_echo_command(cmd)) { // buffer was not full (else we will retry later) if (c) // newline char?
if (c) queued_commands_P += i + 1; // advance to the next command
queued_commands_P += i; // move to next command else
else queued_commands_P = NULL; // nul char? no more commands
queued_commands_P = NULL; // no more commands in the sequence
}
} }
} }
return (queued_commands_P != NULL); // any more left to add? return (queued_commands_P != NULL); // return whether any more remain
} }
/** /**