melch/Marlin
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update M7219 comment, tweak parameter code

Browse Source
This commit is contained in:
Scott Lahteine 2019-07-24 21:06:42 -05:00
parent b6095fd084
commit a3dc1e461b
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Marlin/src/gcode/feature/leds/M7219.cpp
View File

@ -33,13 +33,16 @@
* I - Initialize (clear) the matrix * I - Initialize (clear) the matrix
* F - Fill the matrix (set all bits) * F - Fill the matrix (set all bits)
* P - Dump the led_line[] array values * P - Dump the led_line[] array values
* C<column> - Set a column to the 8-bit value V * C<column> - Set a column to the bitmask given by 'V' (Units 0-3 in portrait layout)
* R<row> - Set a row to the 8-bit value V * R<row> - Set a row to the bitmask given by 'V' (Units 0-3 in landscape layout)
* X<pos> - X position of an LED to set or toggle * X<pos> - X index of an LED to set or toggle
* Y<pos> - Y position of an LED to set or toggle * Y<pos> - Y index of an LED to set or toggle
* V<value> - The potentially 32-bit value or on/off state to set * V<value> - LED on/off state or row/column bitmask (8, 16, 24, or 32-bits)
* (for example: a chain of 4 Max7219 devices can have 32 bit * ('C' / 'R' can be used to update up to 4 units at once)
* rows or columns depending upon rotation) *
* Directly set a native matrix row to the 8-bit value 'V':
* D<line> - Display line (0..7)
* U<unit> - Unit index (0..MAX7219_NUMBER_UNITS-1)
*/ */
void GcodeSuite::M7219() { void GcodeSuite::M7219() {
if (parser.seen('I')) { if (parser.seen('I')) {
@ -62,12 +65,13 @@ void GcodeSuite::M7219() {
else if (parser.seenval('X') || parser.seenval('Y')) { else if (parser.seenval('X') || parser.seenval('Y')) {
const uint8_t x = parser.byteval('X'), y = parser.byteval('Y'); const uint8_t x = parser.byteval('X'), y = parser.byteval('Y');
if (parser.seenval('V')) if (parser.seenval('V'))
max7219.led_set(x, y, parser.boolval('V')); max7219.led_set(x, y, v > 0);
else else
max7219.led_toggle(x, y); max7219.led_toggle(x, y);
} }
else if (parser.seen('D')) { else if (parser.seen('D')) {
const uint8_t line = parser.byteval('D') + (parser.byteval('U') << 3); const uint8_t uline = parser.value_byte() & 0x7,
line = uline + parser.byteval('U') << 3;
if (line < MAX7219_LINES) { if (line < MAX7219_LINES) {
max7219.led_line[line] = v; max7219.led_line[line] = v;
return max7219.refresh_line(line); return max7219.refresh_line(line);